Coupon applied before email is filled – shop email ends up on the order?

Hi,

we ran into a slightly odd behaviour in VMuikitx One Page Checkout (10.50) and wanted to check if this is expected.

If a guest applies a coupon before they have entered their email, the order can later be saved with the site’s Joomla “From” address (mailfrom) as the customer email. After a cart reload that address also shows up in the email field. If the customer doesn’t change it, that’s what goes on the order.

We noticed it because a few real orders came in with our own shop email instead of the customer’s. Looking around, it seems plugins/system/vmuikitx_onepage/cart/applycoupon.php fills mailfrom into the cart when the email is still empty.

Is this by design, maybe so VirtueMart can check the coupon without an email yet? In our case it can silently overwrite the customer address, which is a bit unfortunate.

Thanks!